-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase - Add Mock::App
component in showcase to easily mock a product application in a frameless page
#2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
force-pushed
the
showcase-add-mock-app
branch
from
November 1, 2024 10:42
5bcbf44
to
7f10e27
Compare
alex-ju
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall – it should save us some time with future extensive page mocks.
This looks great and should be very convenient to use, thanks! |
2 tasks
KristinLBradley
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is a porting of https://github.com/hashicorp/hds-plus/pull/41 in HDS (with some tweaks, that later I'll port back to HDS+).
The idea comes from the observation of how much code @KristinLBradley (and then @philrenaud) had to write (copy&paste) to mock a "product application" in a frameless page.
That's why I've decided to abstract away all that code in a
Mock::App
so that ultimately to render this page:it's enough to write this code:
Note: I've used the
Mock
namespace because in the future we may want to mock other complex UI parts (tables with filter and pagination, forms, etc)🛠️ Detailed description
In this PR I have:
Mock::App
component for showcasetypes
folder (leftover?)Mock::App
Preview of the converted pages:
(for the last two, I have used placeholders instead of the
AppHeader/AppSideNav
, for the time being; we can easily add these components to theMock::App
and demo pages, if/when we will publish theAppHeader/AppSideNav
components)👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.