Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LegacyConfigPropertiesLoader should not suppress ParseException #16133

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Oct 24, 2024

Description:

Related issue(s):

Fixes #16132
Fixes https://github.com/hashgraph/solo-operator/issues/233

Notes for reviewer:

During boot time, platform shouldn't try to resolve the FQDN addresses (internal or external) in the config.txt as other nodes may not be up by the time a node starts parsing config.txt. So this PR removes FQDN resolution at config parsing time.

Also it throws exception if config.txt parsing fails for other reasons at the boot time.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@leninmehedy leninmehedy force-pushed the 16132-do-not-suppress-parse-exception branch from 0f7b3db to 9a59e75 Compare October 24, 2024 02:33
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (b447146) to head (9a59e75).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...rm/config/legacy/LegacyConfigPropertiesLoader.java 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16133      +/-   ##
=============================================
+ Coverage      58.02%   58.04%   +0.01%     
- Complexity     19744    19749       +5     
=============================================
  Files           2724     2724              
  Lines          99673    99665       -8     
  Branches       10289    10287       -2     
=============================================
+ Hits           57834    57846      +12     
+ Misses         38233    38216      -17     
+ Partials        3606     3603       -3     
Files with missing lines Coverage Δ
...rlds/platform/system/address/AddressBookUtils.java 72.85% <ø> (+2.02%) ⬆️
...rm/config/legacy/LegacyConfigPropertiesLoader.java 69.23% <0.00%> (+4.01%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b447146) 99490 61303 61.62%
Head commit (9a59e75) 99482 (-8) 61312 (+9) 61.63% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16133) 3 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@leninmehedy leninmehedy marked this pull request as ready for review October 25, 2024 04:25
@leninmehedy leninmehedy requested a review from a team as a code owner October 25, 2024 04:25
Copy link
Contributor

@litt3 litt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NetworkUtils has no remaining usages, and may be deleted. Otherwise LGTM

@leninmehedy leninmehedy added this to the v0.57 milestone Oct 25, 2024
@leninmehedy
Copy link
Member Author

leninmehedy commented Oct 25, 2024

Just holding off merging it since this PR may not be sufficient to fix all the issues. I have documented my observations, current workarounds and related problems here for reference and offline discussions: https://www.notion.so/swirldslabs/Problem-DNS-lookup-issue-during-Platform-boot-1297c9ab259180fdbc2fe97019d7d7fd?pvs=4

We'll come back to it once I get confirmations from others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LegacyConfigPropertiesLoader should not suppress ParseException
3 participants