00672 RewardTransferGraph unit test randomly fails #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes below fix a latent issue in
HbarAmount
unit test causingRewardTransferGraph
to break randomly.HbarAmount
defines a mock forapi/v1/network/exchangerate
at the top level (ie outside ofdescribe()
function).This mock remains active during execution of all the tests.
RewardTransferGraph
does not define any mock forapi/v1/network/exchangerate
and does not expect any dollar values.When
RewardTransferGraph
unit test is executed beforeHbarAmount
, it succeeds.When
RewardTransferGraph
unit test is executed after, it breaks becauseHbarAmount
mock returns some unexpected dollar values.Change below make sure that
HbarAmount
dismantles its mock after its execution.Related issue(s):
Fixes #672
Notes for reviewer:
It's possible to force vitest to execute
HbarAmount
beforeRewardTransferGraph
using:Checklist