00672 RewardTransferGraph unit test randomly fails

[ericleponner]

Description:

Changes below fix a latent issue in HbarAmount unit test causing RewardTransferGraph to break randomly.

HbarAmount defines a mock for api/v1/network/exchangerate at the top level (ie outside of describe() function).
This mock remains active during execution of all the tests.
RewardTransferGraph does not define any mock for api/v1/network/exchangerate and does not expect any dollar values.

When RewardTransferGraph unit test is executed before HbarAmount, it succeeds.
When RewardTransferGraph unit test is executed after, it breaks because HbarAmount mock returns some unexpected dollar values.

Change below make sure that HbarAmount dismantles its mock after its execution.

Related issue(s):

Fixes #672

Notes for reviewer:

It's possible to force vitest to execute HbarAmount before RewardTransferGraph using:

rm -rf  node_modules/.vitest # Clears vitest cache to force alphabetic (?) ordering
npx vitest run --threads false HbarAmount RewardTransferGraph

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	90.8%	29107 / 32056
🔵	Statements	90.8%	29107 / 32056
🔵	Functions	71.67%	726 / 1013
🔵	Branches	84.59%	3392 / 4010

File Coverage

No changed files found.

Generated in workflow #407

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication