Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token actions activation and table refresh #1462

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Oct 25, 2024

Description:

  • As a follow-up to feat: support for HIP-904: Frictionless Airdrops #1448, fixes several issues related to Token Actions:
    • activation of REJECT only if connected to Hedera wallet and balance > 0
    • refresh tables after token actions are completed
  • Replace use of (soon to be retired) TokenRelationshipCache by TokenAssociationCache

Notes for reviewer:

Deployed on staging server.

Copy link

github-actions bot commented Oct 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.98% 24563 / 32758
🔵 Statements 74.98% 24563 / 32758
🔵 Functions 59.92% 993 / 1657
🔵 Branches 84.07% 4742 / 5640
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/account/RejectTokenDialog.vue 37.27% 66.66% 25% 37.27% 31, 60-63, 85-93, 150, 154-156, 162-174, 198-199, 212-214, 216-240, 244-289, 296-298, 300-307, 309-313, 315-322, 324-339, 341, 343-353, 355, 357-369, 371-372
src/components/token/TokenActions.vue 25.17% 100% 0% 25.17% 164-170, 175-180, 182-184, 186-195, 198-221, 226-231, 236-237, 242-247, 252-253, 259-265, 270-271, 273-281, 286-287, 289-301, 306-307, 309-317, 322-345, 350-357, 362-366, 371-376, 378-385, 387-398, 403-425, 430-475, 480-489, 491-503, 508-523, 526-565
src/components/token/TokenCell.vue 98.86% 86.66% 100% 98.86% 131
src/pages/TokenDetails.vue 97.68% 97.22% 66.66% 97.68% 435, 468-473, 508-509
Generated in workflow #1414

Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit deaaafc into main Oct 25, 2024
11 of 12 checks passed
@svienot svienot deleted the fix-token-actions branch October 25, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants