Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet logo is not displaying #1440

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: wallet logo is not displaying #1440

merged 1 commit into from
Oct 17, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below update URL used by Explorer for representing Blade Wallet.
Right now it uses picture at https://www.bladewallet.io/wp-content/uploads/2022/04/BladeWalletWhite.svg.
This file no longer exists.
Changes below replace URL above by the same image embedded in a data URL.

Related issue(s):

Fixes #1439

Notes for reviewer:
Clean your cache thoroughly before testing ;)

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 76.77% 23708 / 30879
🔵 Statements 76.77% 23708 / 30879
🔵 Functions 61.09% 972 / 1591
🔵 Branches 84.14% 4645 / 5520
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/wallet/WalletDriver_Blade.ts 14.04% 100% 20% 14.04% 52-70, 72-81, 83, 85-88, 91-101, 104-105, 112-122, 125-132, 139-152, 155-170, 173-180
Generated in workflow #1370

Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
(I have also tested locally in a private window).

@ericleponner ericleponner merged commit ad6ff0f into main Oct 17, 2024
11 of 12 checks passed
@ericleponner ericleponner deleted the fix_blade_icon branch October 17, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet logo is not displaying
2 participants