Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add airdrop related transaction types #1433

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Oct 17, 2024

Description:

  • Transaction types TOKEN AIRDROP, TOKEN CLAIM AIRDROP and TOKEN CANCEL AIRDROP are available on all networks so these types are now enabled in the Transaction Type Selector (i.e. no longer conditioned by VITE_APP_ENABLE_AIRDROP variable).
  • Remove parts of unit tests checking the effect of VITE_APP_ENABLE_AIRDROP.
  • Enable display of token transfer graphs in transaction summary for additional types of transactions: TOKEN REJECT, TOKEN AIRDROP, TOKEN CLAIM AIRDROP.

Related issue(s):

Fixes #1325

Notes for reviewer:
Screenshot 2024-10-17 at 11 04 55
Screenshot 2024-10-17 at 11 06 10
Screenshot 2024-10-17 at 11 06 53

…o those showing (potentially) a transfer graph in their summary.

Signed-off-by: Simon Viénot <[email protected]>
…action types in Transactions filter.

Signed-off-by: Simon Viénot <[email protected]>
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 76.71% 23718 / 30916
🔵 Statements 76.71% 23718 / 30916
🔵 Functions 60.97% 972 / 1594
🔵 Branches 84.14% 4644 / 5519
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/transaction/TransactionFilterSelect.vue 100% 100% 50% 100%
src/components/transaction/TransactionSummary.vue 87.34% 80% 100% 87.34% 41, 93-101
Generated in workflow #1359

Copy link

sonarcloud bot commented Oct 17, 2024

@ericleponner ericleponner merged commit 40fe4eb into main Oct 17, 2024
12 checks passed
@ericleponner ericleponner deleted the 1325-add-airdrop-related-transaction-types branch October 17, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Token Claim, Airdrop, and Cancel transaction types
2 participants