Improve layout table printing #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the layout table printing by removing the empty gap
at the end of a row for non-single element rows. This means that previously
the layout table would print for a struct like this:
```rs
\#layout_of Boon := enum(
Foo(x: i32, y: i32),
Faz(z: f64),
);
```
Before:
```
info: Layout of `Boon` (size=16b align=8b):
┌──────────────┬─────────────────────────┐
│ 4b tag (u32) │ │
├──────────────┼────────────┬────────────┤
│ Foo │ x: i32 │ y: i32 │
│ │ │ │
│ 0 │ size: 4b │ size: 4b │
│ │ offset: 4b │ offset: 8b │
│ │ align: 4b │ align: 4b │
├──────────────┼────────┬───┴────────┬───┤
│ Faz │ 4b pad │ z: f64 │ │
│ │ │ │ │
│ 1 │ ## │ size: 8b │ │
│ │ ## │ offset: 8b │ │
│ │ ## │ align: 8b │ │
└──────────────┴────────┴────────────┴───┘
```
After the change, we now print the following:
```
info: Layout of `Boon` (size=16b align=8b):
┌──────────────┬─────────────────────────┐
│ 4b tag (u32) │ │
├──────────────┼────────────┬────────────┤
│ Foo │ x: i32 │ y: i32 │
│ │ │ │
│ 0 │ size: 4b │ size: 4b │
│ │ offset: 4b │ offset: 8b │
│ │ align: 4b │ align: 4b │
├──────────────┼────────┬───┴────────────┤
│ Faz │ 4b pad │ z: f64 │
│ │ │ │
│ 1 │ ## │ size: 8b │
│ │ ## │ offset: 8b │
│ │ ## │ align: 8b │
└──────────────┴────────┴────────────────┘
```
kontheocharis
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## Description
This PR improves the layout table printing by removing the empty gap
at the end of a row for non-single element rows. This means that previously
the layout table would print for a struct like this:
Before:
After the change, we now print the following: