Various metrics comms fixes #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.cargo/config.toml
Outdated
| @@ -1,6 +1,7 @@ | |||
| [build] | |||
| rustdoc = "rustdoc" | |||
| rustdocflags = ["--show-type-layout", "-Z", "unstable-options"] | |||
| rustflags = ["-L", "/opt/homebrew/lib/"] | |||
There was a problem hiding this comment.
Surely this shouldn't exist here?
There was a problem hiding this comment.
Ugh yes it really shouldn’t, but for some reason ld on mac is refusing to find zstd installed on my machine. This is the only way I found to fix it. This will be ignored on systems that this doesn’t exist since its only meant to “indicate” where to look for this libraries.
There was a problem hiding this comment.
True, it won't really hurt others I guess
There was a problem hiding this comment.
I would love to remove this dumb hack, I will leave a ##Hack
There was a problem hiding this comment.
This now magically works - I think I had a borked installation locally. Removed!
kontheocharis
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstdis added to link pathmessaging_formatis propagated from--configure--configureunknown fields