messaging #1067
Merged
messaging #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub mod stream; | ||
|
|
||
| use hash_pipeline::settings::CompilerSettings; | ||
| use hash_reporting::report::Report; |
There was a problem hiding this comment.
We need to figure out how to not expose compiler internals here...
There was a problem hiding this comment.
Yep, we definitely need to decide what to keep internal or external!
…::*` infrastructure
This is needed in to support the new policy of using `log::info!` for logging and outputting useful compiler information to the user. During testing however, we don't capture the logger and don't initialise it with our custom logging interface. This commit changes that. Also, due to some of the format changes in information output, some tests are updated to reflect the new output.
kontheocharis
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hash-messagingcrate for input/output messagestracyfeature name--schemaoption--configureflag for configuring the compilerThis is a huge step towards #1038