parser: correctly highlight the redundant parenthesees when emitting …

…warnings
hash-org · Aug 31, 2023 · 20a8df8 · 20a8df8
1 parent 72beee8
commit 20a8df8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/compiler/hash-parser/src/parser/expr.rs b/compiler/hash-parser/src/parser/expr.rs
@@ -885,7 +885,7 @@ impl<'stream, 'resolver> AstGen<'stream, 'resolver> {
             if !matches!(expr.body(), Expr::BinaryExpr(_) | Expr::Cast(_) | Expr::FnDef(_)) {
                 self.add_warning(ParseWarning::new(
                     WarningKind::RedundantParenthesis(expr.body().into()),
-                    expr.span(),
+                    gen.span(),
                 ));
             }
 

diff --git a/tests/cases/parser/blocks/parenthesised_match_statement.stderr b/tests/cases/parser/blocks/parenthesised_match_statement.stderr
@@ -1,25 +1,25 @@
 warn: unnecessary parentheses around block
-  --> $DIR/parenthesised_match_statement.hash:3:8
+  --> $DIR/parenthesised_match_statement.hash:3:7
 2  |    
 3  |    b := ((match some_struct {
-   |  _________-
+   |  ________-
 4  | |      Dog(name, age = 6) => match name {
 5  | |          "Viktor" => print("Viktor is 6"),
 ...  |
 10 | |      Dog(name, age) => do_something_with_name(),
 11 | |      _ => unreachable()
 12 | |  }));
-   | |__- 
+   | |___- 
 
 warn: unnecessary parentheses around block
-  --> $DIR/parenthesised_match_statement.hash:3:8
+  --> $DIR/parenthesised_match_statement.hash:3:6
 2  |    
 3  |    b := ((match some_struct {
-   |  _________-
+   |  _______-
 4  | |      Dog(name, age = 6) => match name {
 5  | |          "Viktor" => print("Viktor is 6"),
 ...  |
 10 | |      Dog(name, age) => do_something_with_name(),
 11 | |      _ => unreachable()
 12 | |  }));
-   | |__- 
+   | |____-