Moving to Python3 #247
Merged
Moving to Python3 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2020 20:05
jace
approved these changes
Jan 14, 2020
.travis.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| language: python | |||
| python: | |||
| - "2.7" | |||
| - "3.6" | |||
hgtv/uploads.py
Outdated
| tempfile = StringIO(buf=request.stream.read()) | ||
| if hasattr(request, 'content'): | ||
| tempfile = BytesIO(request.content) | ||
| elif hasattr(request, 'read'): |
There was a problem hiding this comment.
Should be else, or you could end up with no tempfile.
There was a problem hiding this comment.
I suspect this entire block could be better. We shouldn't be doing guesswork here.
| @@ -32,7 +32,7 @@ def channel_edit(channel): | |||
| if channel.userid == current_auth.user.userid: | |||
| form.type.choices = [(1, CHANNEL_TYPE[1])] | |||
| else: | |||
| choices = CHANNEL_TYPE.items() | |||
| choices = list(CHANNEL_TYPE.items()) # requires list() | |||
| choices.pop(0) | |||
| choices.pop(0) | |||
There was a problem hiding this comment.
Could you add a comment explaining why the first two items are being popped?
hgtv/views/video.py
Outdated
| @@ -155,11 +154,11 @@ def process_slides(video): | |||
| raise DataProcessingError("Unable to resolve the URL") | |||
| elif parsed.netloc in ['speakerdeck.com', 'www.speakerdeck.com']: | |||
| try: | |||
| r = urllib2.urlopen('https://speakerdeck.com/oembed.json?url=%s' % video.slides_url) | |||
| r = urllib.request.urlopen('https://speakerdeck.com/oembed.json?url=%s' % video.slides_url) | |||
| jsondata = json.loads(r.read()) | |||
| r.close() | |||
There was a problem hiding this comment.
Separately, this block should switch to requests.
jace
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to hasgeek/hgapp#39