Added Localization support for About and Dashboard #95
Conversation
| @@ -2,6 +2,79 @@ import React from 'react' | |||
|
|
|||
| const PLACEHOLDER = 'XXX' | |||
|
|
|||
| export const TEXT_KEYS = { | |||
There was a problem hiding this comment.
I didn't read about it anywhere but I just felt it would be better than typing long strings with little to no auto-complete support for keys. Putting them all in TEXT_KEYS seemed like a quicker approach for future additions too.
There was a problem hiding this comment.
since we use typescript, there should be autocomplete for strings when using i18n
|
Dear @knightcube - apologies for the delay approving the texts. |
|
Hi @NoamGaash. I completely understand. Please stay safe and I really pray and hope things calm down as soon as possible. |
NoamGaash
force-pushed
the
main
branch
2 times, most recently
from
4467245
to
96ece7d
Compare
| </li> | ||
| ))} | ||
| <button onClick={handleChangeLanguage}>Change Language</button> |
There was a problem hiding this comment.
let's hide this button for now, so we'll be able to merge it within hacktoberfest
| <button onClick={handleChangeLanguage}>Change Language</button> | |
| { null && <button onClick={handleChangeLanguage}>Change Language</button>} |
There was a problem hiding this comment.
Hi @NoamGaash. Sorry for the late reply. Made the changes just now.
Description
This PR Fixes Issue #90
Currently, I have added English language support for 2 pages:-
While implementing this feature I realized that support for RTL and LTR is also required as Hebrew is read from right to left but English is read from left to right.
How do I go about adding RTL support to the project using i18n as it will need changes to too many files?
Perhaps RTL support can be added later in a different PR? 🤔
Happy to know your thoughts on the changes implemented so far.
Screenshots