docs: test commands #91
Conversation
| @@ -23,6 +23,11 @@ This app is created by the volunteers of [Public Knowledge Workshop](https://www | |||
| - `yarn install` | |||
| - `yarn start` | |||
|
|
|||
| ### testing the project: | |||
| - running the tests - `yarn playwright test` | |||
There was a problem hiding this comment.
we have script for it
npm run test:playwright
In addition, What do you think about changing the scripts?
"scripts": { ... "test": "playwright test", "test:ui": "playwright test --ui" ... }
Do we need the "react-scripts test" when we use playwright?
if so we should add,
"test:react-scripts": "react-scripts test"
because we don't use it so often
Afterwards, we will change the docs accordingly.
There was a problem hiding this comment.
Regarding the scripts, I like your suggestion.
Regarding npm run test:playwright - we use yarn, and I'm not sure about the best practice. maybe yarn run test:playwright.
we don't need react-scripts test, but that's for another PR
There was a problem hiding this comment.
Yes, you right , my mistake. I meant yarn run test:playwright in the current scripts.
If you would like first to change the scripts and then change the documentation, the commands will be yarn run test / yarn run test:ui
Tell me what you prefer.
There was a problem hiding this comment.
having yarn run test and yarn run test:ui sounds great
|
Maybe there was a misunderstanding. Do you want me to open an issue about changing the scripts and the Read.me afterwards? (I thought you will make these changes before merging) |
|
I thought you will open a PR, but I can do it as well |
|
Ok, my mistake, I will do it, thanks anyway :) |
|
thank you! #97 great job 💪 |
explain about out test suite