Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove node.js code from browser context #87

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: remove node.js code from browser context #87

merged 1 commit into from
Oct 3, 2023

Conversation

NoamGaash
Copy link
Member

Description

process doesn't exist in a browser context.

@NoamGaash NoamGaash requested a review from rzarviv October 2, 2023 09:09
@NoamGaash NoamGaash enabled auto-merge (squash) October 2, 2023 09:09
@NoamGaash NoamGaash merged commit 5968cb3 into main Oct 3, 2023
4 checks passed
@rzarviv
Copy link
Collaborator

rzarviv commented Oct 3, 2023

I used process.env.publicURL according to CRA's docs:
https://create-react-app.dev/docs/using-the-public-folder/#adding-assets-outside-of-the-module-system

I guess that after moving to Vite it won't be necessary anymore.

Good Job @NoamGaash !

@NoamGaash NoamGaash deleted the fix/remove-node.js-code-from-browser-context branch October 3, 2023 08:25
@NoamGaash
Copy link
Member Author

My mistake - I wasn't aware it could be used in the context of React. Interesting.

@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzarviv rzarviv rzarviv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoamGaash @rzarviv