Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: a couple styling changes #786

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

style: a couple styling changes #786

wants to merge 5 commits into from

Conversation

Sicnecher
Copy link
Collaborator

Changes

  1. Removed duplicate donation button.
  2. Moved the presented precentages at the 'public transport operators' page' into the body of the line to present the line better.
    צילום מסך 2024-06-04 102429

צילום מסך 2024-06-04 235906

  1. Once the app width gets too small the buttons at the home page slip to the sides, instead it now turns into one button that opens the menu.
    צילום מסך 2024-06-04 101934
    צילום מסך 2024-06-04 235937

@Sicnecher Sicnecher requested a review from NoamGaash as a code owner June 5, 2024 15:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9418660037/open-bus/30080db777c8104e86b2ef7030b89fbfa5f8393b/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9418660037/open-bus/30080db777c8104e86b2ef7030b89fbfa5f8393b/storybook/index.html

@NoamGaash
Copy link
Member

is the hovering appearance part of the new design?
image

NoamGaash
NoamGaash requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicnecher @NoamGaash