Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: prevent workflow from failing on forks #66

Merged
merged 4 commits into from
Sep 23, 2023
Merged

ci: prevent workflow from failing on forks #66

merged 4 commits into from
Sep 23, 2023

Commits on Sep 22, 2023

  1. ci: prevent workflow from failing on forks 

    when running on forks, secrets.GITHUB_TOKEN is not available.
I don't want the contributors to see a giant red `x` next to their pull request. That's a bad developer experience.
let's solve it
    @NoamGaash
    NoamGaash authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    6d0ae79 View commit details
    Browse the repository at this point in the history

  2. test: increase timeout

    @NoamGaash
    NoamGaash committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    09f3bcf View commit details
    Browse the repository at this point in the history

  3. fix: syntax

    @NoamGaash
    NoamGaash committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f02e565 View commit details
    Browse the repository at this point in the history

  4. fix: syntax

    @NoamGaash
    NoamGaash committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7066a81 View commit details
    Browse the repository at this point in the history