-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better inputs design fix placement #61
Better inputs design fix placement #61
Conversation
The Playwright Tests run when the server is busy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layout of the input fields looks great now, thanks. I have only some minor comments for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments :)
OK. |
fix the comments. for another PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, I have only some comments.
const value = ts ? ts.format() : '' | ||
setFrom(value) | ||
setTo(formatTime(+new Date(value) + (+new Date(to) - +new Date(from)))) // keep the same time difference | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should declare the function that you use in setTimeValid before returning the JSX (rendering the content) and use it here and in setTimeValid of TimeSelector so you don't duplicate code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the state form
and the state to
design before Noam adds the load date from the URL feature.
I prefer to remove the state to
completely.
add the minutes when we call useVehicleLocations
.
and use the moment.js
library.
this refactor related to issue #79 and issue #71.
so I prefer to solve this in another PR.
@NoamGaash I reviewed the code , would you like to review it as well? |
@ArkadiK94 @aviv1620 thank you! |
@all-contributors |
I've updated the pull request to add @aviv1620! 🎉 I've put up a pull request to add @ArkadiK94! 🎉 |
comment on issue #39