Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resolve input misalignment issue #52

Conversation

Mordechai1323
Copy link
Collaborator

No description provided.

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution! please add before & after screenshot

@Mordechai1323
Copy link
Collaborator Author

before
image

after
image

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution, but please use flex to align the fields with the labels
https://www.reddit.com/r/css/comments/v29lzs/this_is_so_frustrating_how_do_i_align_these/
using constant width is a bad practice - consider a scenario where we will change some of the texts, or change the font sizing - it will break your solution

@NoamGaash
Copy link
Member

please re-open if it will be relevant again :)

@NoamGaash NoamGaash closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants