Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #43

Merged
merged 5 commits into from
Sep 17, 2023
Merged

Update README.md #43

merged 5 commits into from
Sep 17, 2023

Conversation

ArkadiK94
Copy link
Collaborator

Fork the Repo First
When I only cloned the project , I tried to push but I got the Error:"Permission to hasadna/open-bus-map-search.git denied to ArkadiK94."
Afterwards, I did it with Forking first and creating pull request, it worked for me.
I edited the Readme for easy way to contribute to the project.
@ShayAdler @NoamGaash

add important step to run the project
@ShayAdler ShayAdler self-requested a review September 16, 2023 17:15
Copy link
Collaborator

@ShayAdler ShayAdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArkadiK94
Copy link
Collaborator Author

ArkadiK94 commented Sep 16, 2023

Hi, should I look in the test cases to see why they don't work? I believe it doesn't relate to my changes because I only changed one line in the readme file in this pr. However, I can look into those cases to try figure out the problem and try to fix it.

@NoamGaash
Copy link
Member

@ShayAdler @ArkadiK94
I'm not sure why the test isn't passing.
I've tried fixing and enhancing the tests on this branch -
#45
I'll try to fix it there.

@NoamGaash NoamGaash merged commit df5605b into hasadna:main Sep 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants