Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #205: GitHub repo link #221

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

xoRmalka
Copy link
Member

Resolving #205

Description

Mobile:

  • Add a logo to the sidebar menu.

Mobile & Desktop:

  • Add a GitHub icon that navigates to the repo link.
  • Add dividers to the sidebar menu.

screenshots

Desktop:

image

Mobile:
image

Add a GitHub icon that navigates to the repo link.

Add dividers to the sidebar menu.
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit 382cecb
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/655502197ffc2d0008b71624
😎 Deploy Preview https://deploy-preview-221--astonishing-pothos-5f81bd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love your style!
but - can you use i18n instead of the texts.tsx file?

@xoRmalka
Copy link
Member Author

@NoamGaash

Thank you!
About the i18n texts, done :)

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoamGaash NoamGaash merged commit 305cae2 into hasadna:main Nov 15, 2023
11 checks passed
@xoRmalka xoRmalka deleted the github-repo-link branch November 15, 2023 19:44
Comment on lines +17 to +19
const handleClick = () => {
window.open(data.path, '_blank')
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const handleClick = () => {
window.open(data.path, '_blank')
}
const handleClick = useCallback(() => {
window.open(data.path, '_blank')
}, [])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants