#issue 187 lazy load - dynamic import #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NoamGaash
changed the title
NoamGaash
requested changes
Nov 14, 2023
KazemHe
force-pushed
the
lazy/load-Suspense
branch
from
0290656
to
68a6f47
Compare
shootermv
approved these changes
Nov 15, 2023
NoamGaash
requested changes
Nov 15, 2023
Comment on lines
+3
to
+11
| import React, { lazy, Suspense } from 'react' | ||
| const DashboardPage = lazy(() => import('../pages/dashboard/DashboardPage')) | ||
| const TimelinePage = lazy(() => import('../pages/TimelinePage')) | ||
| const GapsPage = lazy(() => import('../pages/GapsPage')) | ||
| const GapsPatternsPage = lazy(() => import('../pages/gapsPatterns')) | ||
| const RealtimeMapPage = lazy(() => import('../pages/RealtimeMapPage')) | ||
| const SingleLineMapPage = lazy(() => import('../pages/SingleLineMapPage')) | ||
| const About = lazy(() => import('../pages/About')) | ||
| import CircularProgress from '@mui/material/CircularProgress' |
There was a problem hiding this comment.
it won't do the trick.
we want to wait with the loading until the user clicks the menu item - that's not what your code is doing
There was a problem hiding this comment.
my bad.
after reading the documentation, you're 100% right.
it will solve the issue perfectly.
thanks!
NoamGaash
approved these changes
Nov 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implemented lazy loading for the pages using daynamic import #issue 187