feat: create line profile page #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'main' of https://github.com/VSciFlight/open-bus-map-search: Added Unit Test for Menu.tsx (#154) Added Localization support for About and Dashboard (#95) docs: update link to api repo at readme (#150) updated HbarChart style (#152) Reverse the timeline graph XAxis to be with 'ltr' orientation (#149) remove unnecessary console.log remove unnecessary console.log hotfix: operatorRefField (#142) [Bug] Fix GapsPatternsPage layout [Bug] Fix Dashboard Layout (also in Mobile) docs: better styling for testing instructions Test - use advanced HAR (#140) Add github lint workflow file (#141) Refactoring of the Sidebar component and its styling (#138) feat(useVehicleLocations): support operatorRef (#96) feat: auto complaint generation (#136) Create dependabot.yml (#135) Update package.json refactor: test commands
changed directory for the gaps component
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NoamGaash
reviewed
Nov 14, 2023
…us-map-search into profile_page_1 * 'profile_page_1' of https://github.com/VSciFlight/open-bus-map-search: issue #193: Profile page creation and a template
NoamGaash
requested changes
Nov 14, 2023
| }) | ||
| { | ||
| return ( | ||
| <div className="chart"> |
There was a problem hiding this comment.
please split to smaller sub components
…us-map-search into profile_page_1 * 'profile_page_1' of https://github.com/VSciFlight/open-bus-map-search: chore: upgrade linter (#217) test: improve dashboard and single-line tests (#192) ci: publish storybook (#213)
…us-map-search into profile_page_1 * 'profile_page_1' of https://github.com/VSciFlight/open-bus-map-search: Slack link update (#225) issue #205: GitHub repo link (#221) #issue 187 lazy load - dynamic import (#218)
NoamGaash
reviewed
Nov 18, 2023
NoamGaash
reviewed
Nov 18, 2023
NoamGaash
approved these changes
Nov 18, 2023
|
i need some explanation please, if i want to access the profile page, where should be a link leading to it? |
|
@shootermv there isn't a link at this point due work in progress. you can access the profile page at "/profile" |
|
@VSciFlight have you seen the linter output? |
|
|
…us-map-search into profile_page_1 * 'profile_page_1' of https://github.com/VSciFlight/open-bus-map-search: another fix, praying to work successfully
Closed
NoamGaash
changed the title
|
So, I have made changes to the page and left the modules that don't crash (for now) or having issues with them. |
…us-map-search into profile_page_1 * 'profile_page_1' of https://github.com/VSciFlight/open-bus-map-search: Replace sort by date and remove reversed (#237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a profile page accessible only by the path of '/profile'
things left to do:
screenshots