Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #193: Profile page creation and a possible template #214

Closed
wants to merge 7 commits into from
Closed

issue #193: Profile page creation and a possible template #214

wants to merge 7 commits into from

Conversation

VSciFlight
Copy link
Contributor

Description

Added a profile page

  • it has the inputs to determine the line the user intends to see
  • an empty timetable
  • presumably a timeline graph of that bus comparing the schedule against reality (now it is recommended to see it as template).

things left to do:

  • integrate the inputs to the profile so that the profile shows the info according to the line it received
  • fixed timetable that fetch the timetable for that line
  • graph shows relevant information

screenshots

image



* 'main' of https://github.com/VSciFlight/open-bus-map-search:
  Added Unit Test for Menu.tsx (#154)
  Added Localization support for About and Dashboard (#95)
  docs: update link to api repo at readme (#150)
  updated HbarChart style (#152)
  Reverse the timeline graph XAxis to be with  'ltr' orientation (#149)
  remove unnecessary console.log
  remove unnecessary console.log
  hotfix: operatorRefField (#142)
  [Bug] Fix GapsPatternsPage layout
  [Bug] Fix Dashboard Layout (also in Mobile)
  docs: better styling for testing instructions
  Test - use advanced HAR (#140)
  Add github lint workflow file (#141)
  Refactoring of the Sidebar component and its styling (#138)
  feat(useVehicleLocations): support operatorRef (#96)
  feat: auto complaint generation (#136)
  Create dependabot.yml (#135)
  Update package.json
  refactor: test commands
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for astonishing-pothos-5f81bd failed.

Name Link
🔨 Latest commit c374bd5
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/65534ac53abed5000874b898

Comment on lines +117 to +134
<SideBar pages={PAGES} />
<Layout>
<StyledContent>
<StyledBody>
<Routes>
<Route path={PAGES[0].key} element={<DashboardPage />} />
<Route path={PAGES[1].key} element={<TimelinePage />} />
<Route path={PAGES[2].key} element={<GapsPage />} />
<Route path={PAGES[3].key} element={<GapsPatternsPage />} />
<Route path={PAGES[4].key} element={<RealtimeMapPage />} />
<Route path={PAGES[5].key} element={<SingleLineMapPage />} />
<Route path={PAGES[6].key} element={<About />} />
<Route path={'/profile'} element={<Profile />} />
<Route path="*" element={<RedirectToDashboard />} />
</Routes>
</StyledBody>
</StyledContent>
</Layout>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you didn't do it on purpose
anyway, when solving conflicts with the main branch, please prefer the coding style from the main branch
see this -
#186
what IDE you're using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode

</tr>

<tr>
<td>אוטובוס אחרון</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using i18n will be nicer

changed directory for the gaps component
@VSciFlight VSciFlight closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants