Map tooltip bus #114
Merged
Map tooltip bus #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug - Open Menu In the Mobile Display hasadna#64
Bug - Open Menu In the Mobile Display hasadna#64
Bug - Open Menu In the Mobile Display hasadna#64
open hasadna#113 issue for it
NoamGaash
requested changes
Oct 11, 2023
src/api/siriService.ts
Outdated
| siriRouteLineRefs: string, | ||
| ) { | ||
| const gtfs_route_promise: SiriRideWithRelatedPydanticModel[] = await SIRI_API.siriRidesListGet({ | ||
| limit: 122, |
There was a problem hiding this comment.
122?
Suggested change
| limit: 122, |
There was a problem hiding this comment.
lol maybe by mistake it should be 1
src/pages/RealtimeMapPage.tsx
Outdated
| </Marker> | ||
| ))} | ||
| {positions.map((pos, i) => { | ||
| const icon = colorIcon({ |
only keep Grid as I see it using in another place in the project
only keep Grid as I see it using in another place in the project
only keep Grid as I see it using in another place in the project
only keep Grid as I see it using in another place in the project
NoamGaash
requested changes
Oct 15, 2023
| {TEXTS.destination} : | ||
| <span>{siriRide && siriRide!.gtfsRouteRouteLongName?.split('<->')[1]}</span> | ||
| </h4> | ||
| <h4 style={{ textAlign: 'start' }}> |
There was a problem hiding this comment.
please try to avoid inline CSS 🙃
There was a problem hiding this comment.
done!
there is another place you use sx
anyway I added scss file for it
Comment on lines
43
to
44
| <Grid container display="flex" direction="row-reverse" justifyContent="space-between"> | ||
| <Grid item xs={4}> |
There was a problem hiding this comment.
let's avoid abusing the grid system - it's not necessary here. we can apply CSS. it can be on seperate PR
NoamGaash
approved these changes
Oct 16, 2023
|
🥳 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve #84
add a nice tooltip with info about the bus.
with an option to see the old JSON .
screenshots
with style card
on mobile
Desktop
with old json
