Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved colorIcon and change to busIcon #103

Merged
merged 8 commits into from
Oct 14, 2023
Merged

Moved colorIcon and change to busIcon #103

merged 8 commits into from
Oct 14, 2023

Conversation

guyStrauss
Copy link
Contributor

@guyStrauss guyStrauss commented Oct 8, 2023 •
edited by rzarviv
Loading

Description

  • Change colorIcon to busIcon and moved to under utils/

close #40

@rzarviv rzarviv self-requested a review October 9, 2023 06:26
rzarviv
rzarviv approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@rzarviv rzarviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @guyStrauss!

@rzarviv rzarviv requested a review from NoamGaash October 9, 2023 06:30
NoamGaash
NoamGaash approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! 🏅

@NoamGaash NoamGaash enabled auto-merge (squash) October 9, 2023 08:03
@NoamGaash
Copy link
Member

image

auto-merge was automatically disabled October 9, 2023 18:12

Head branch was pushed to by a user without write access

@NoamGaash NoamGaash enabled auto-merge (squash) October 10, 2023 08:39
@NoamGaash
Copy link
Member

great job! thank you 🙏 ⭐

@NoamGaash
Copy link
Member

the linter can be ran locally by using the yarn run lint command :)

@guyStrauss
Copy link
Contributor Author

the linter can be ran locally by using the yarn run lint command :)

Yes I set my vs code to auto lint every save, I probably merge requested before fixing the issue

@NoamGaash
Copy link
Member

the linting fail on the latest commit of this branch - so please make sure you pushed all of your changes,
thank you 🙏

@NoamGaash
Copy link
Member

@guyStrauss this kind of warnings doesn't get automatically fixed
image

auto-merge was automatically disabled October 14, 2023 11:37

Head branch was pushed to by a user without write access

@guyStrauss
Copy link
Contributor Author

Hey @NoamGaash
Fixed the lint problems, and merged main into this current branch to make sure there are no conflits

@NoamGaash NoamGaash enabled auto-merge (squash) October 14, 2023 14:45
@NoamGaash NoamGaash merged commit 2028c86 into hasadna:main Oct 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzarviv rzarviv rzarviv approved these changes

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move colorIcon To a Separate File
3 participants
@guyStrauss @NoamGaash @rzarviv