Added invalid dates warning and out of range date warning #101
Conversation
|
Yes of course, I will fix it and push the changes |
|
thank you! 🥇 ⭐ |
|
let's fix the build and merge it |
|
ok, I'm on it |
NoamGaash
force-pushed
the
main
branch
2 times, most recently
from
4467245
to
96ece7d
Compare
|
@AviadCohen24 do you need any help? |
|
Well, I pushed again with some fixes that you suggest, and I have to say that even that i didn`t add a lot of code lines in that PR, i learned how to be more "cleaner" in my code, for example- the warning selector, at the start I though about using function that handle different error states, but because of this PR I learned that i can use an object and indexes (like you suggested) and make it more simple than using function |
|
@AviadCohen24 thank you! how exciting it is to hear that. |
|
@NoamGaash Ok, I`m on it |
|
you'll have to fix the build before merging |
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
the reason for merge conflicts now - is that instead of DatePicker mui component, dashboard page is now uses DateSelector component (which is our extension for mui DatePicker) |
|
i wonder, what is the status here, @AviadCohen24 are you still work on it? |
|
@shootermv Sorry, but unfortunately I'm in a busy period with the situation in Israel and I don't have time to work on it. If someone else can help me with this and take care of what is needed I would greatly appreciate it |
|
No prob, |
shootermv
force-pushed
the
DatePickerWarning
branch
2 times, most recently
from
7b5781f
to
c53cca7
Compare
shootermv
force-pushed
the
DatePickerWarning
branch
from
c53cca7
to
c8321a2
Compare
|
@shootermv Hi, why did you close this pr? |
|
Hi. I deleted all the chnages by mistake. Sorry.
Totally my bad
…On Sun, Nov 19, 2023, 21:12 Arkadi Koifman ***@***.***> wrote:
@shootermv <https://github.com/shootermv> Hi, why did you close this pr?
—
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKGMHW67ROLRFHKWLFUYRDYFJK2DAVCNFSM6AAAAAA5WOWSDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHE2DSNJYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have the chnages locally. I think i will try to ask Aviad to open the pr
again
…On Sun, Nov 19, 2023, 21:47 Moshe Vilner ***@***.***> wrote:
Hi. I deleted all the chnages by mistake. Sorry.
Totally my bad
On Sun, Nov 19, 2023, 21:12 Arkadi Koifman ***@***.***>
wrote:
> @shootermv <https://github.com/shootermv> Hi, why did you close this pr?
>
> —
> Reply to this email directly, view it on GitHub
> <#101 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAKGMHW67ROLRFHKWLFUYRDYFJK2DAVCNFSM6AAAAAA5WOWSDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHE2DSNJYGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Hi @AviadCohen24 |
|
Of course, tomorrow I'll finally have time to do it. Sorry about the delay 😅 |
I did :) |
|
I have your code saved at my local machine if you need... |
Added a warning to select date that inside the dates range. the selected range for now it's from 01-01-2010 until every day
Added a warning for invalid dates.
Close #80