Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker component | show invalid dates warning #80

Closed
ArkadiK94 opened this issue Sep 30, 2023 · 15 comments · Fixed by #398
Closed

DatePicker component | show invalid dates warning #80

ArkadiK94 opened this issue Sep 30, 2023 · 15 comments · Fixed by #398
Assignees
Labels
CSS related to the design, without affecting business logic frontend frontend developers issue good first issue Good for newcomers hacktoberfest

Comments

@ArkadiK94
Copy link
Collaborator

ArkadiK94 commented Sep 30, 2023

For now, when the user selects an invalid Date, the box is marked in red.
I think it is better to add some warning in words so the user will understand why it is red...
image
In addition, we should make sure that if the user enters a year before X (I think make it 2000 but maybe before or after) it will be marked as well
image

@ArkadiK94
Copy link
Collaborator Author

@NoamGaash @ShayAdler

@NoamGaash NoamGaash added CSS related to the design, without affecting business logic hacktoberfest labels Oct 1, 2023
@NoamGaash
Copy link
Member

text for invalid input: "נא להזין תאריך בפורמט תקין"
the text should be aligned to the right because Hebrew is a right-to-left language.

@NoamGaash NoamGaash added the good first issue Good for newcomers label Oct 1, 2023
@NoamGaash NoamGaash changed the title DatePicker Warning When Selectig not Valid Date DatePicker component | show invalid dates warning Oct 2, 2023
@aviv1620
Copy link
Collaborator

aviv1620 commented Oct 2, 2023

https://mui.com/x/react-date-pickers/validation/#show-the-error

@AviadCohen24
Copy link

hi, can anyone assign this issue to me?

@ArkadiK94
Copy link
Collaborator Author

Sure, you can work on it. See the message from aviv1620.

@AviadCohen24
Copy link

Thank you.
On the topic of adding a possible date range to select, I'm currently doing from the beginning of 2010 until the day before every day, is it ok?

@ArkadiK94
Copy link
Collaborator Author

I am not sure which date range to set. @NoamGaash what do you prefer?

@NoamGaash
Copy link
Member

@AviadCohen24 it's also possible to choose the current date - we should have data up until 1-2 minute ago,

@AviadCohen24
Copy link

@NoamGaash Ok, from what date is there data documented in the API?

@NoamGaash
Copy link
Member

I'm not sure,
you can keep it on 2010, or alternatively check the stride API and sort by date descending order

@AviadCohen24
Copy link

ok.
something else, on my laptop (15.6"), the date picker container look like this:
image
do you want me to take care of it and fix it in this issue or you prefer to open a new issue to take care of it?

@aviv1620
Copy link
Collaborator

aviv1620 commented Oct 6, 2023

Think open new issues.
PR #54 destroy the layout.

And the place need to be here:
Screenshot 2023-10-07 010101

@oribro
Copy link
Contributor

oribro commented Jan 16, 2024

@NoamGaash @ArkadiK94
I've just uploaded a fix to this issue using @aviv1620's suggestion, and also cleaned some previous leftover error message.
I'd appreciate your review 🥇

@aviv1620
Copy link
Collaborator

@oribro
Thank you very much.
The issue it very old. and time to close it.

@NoamGaash
Copy link
Member

@oribro great work, 10x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS related to the design, without affecting business logic frontend frontend developers issue good first issue Good for newcomers hacktoberfest
Projects
None yet
5 participants