move colorByExecution handler to utils

hasadna · Oct 9, 2023 · b528a26 · b528a26
1 parent 42e4396
commit b528a26
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 15 deletions.
diff --git a/src/pages/GapsPatternsPage.tsx b/src/pages/GapsPatternsPage.tsx
@@ -27,8 +27,12 @@ import {
   TooltipProps,
 } from 'recharts'
 import { FormControlLabel, Radio, RadioGroup } from '@mui/material'
-import { GetColorByExecution } from './components/utils/ColorBySeverity'
-import { HourlyData, byHourHandler, bySeverityHandler } from './components/utils'
+import {
+  HourlyData,
+  byHourHandler,
+  bySeverityHandler,
+  mapColorByExecution,
+} from './components/utils'
 
 // Define prop types for the component
 interface BusLineStatisticsProps {
@@ -173,7 +177,7 @@ function GapsByHour({ lineRef, operatorRef, fromDate, toDate }: BusLineStatistic
           {hourlyData.map((entry, index) => (
             <Cell
               key={`cell-${index}`}
-              fill={GetColorByExecution(entry.planned_rides, entry.actual_rides)}
+              fill={mapColorByExecution(entry.planned_rides, entry.actual_rides)}
             />
           ))}
         </Bar>

diff --git a/src/pages/components/utils/ColorBySeverity.tsx b/src/pages/components/utils/ColorBySeverity.tsx
diff --git a/src/pages/components/utils/index.ts b/src/pages/components/utils/index.ts
@@ -21,3 +21,16 @@ export const bySeverityHandler = (a: HourlyData, b: HourlyData) => {
   }
   return b.planned_rides - a.planned_rides
 }
+
+export const mapColorByExecution = (planned: number, actual: number) => {
+  const misses = planned - actual
+  const percentageMisses = (misses / planned) * 100
+
+  if (percentageMisses <= 5) {
+    return 'green'
+  } else if (percentageMisses <= 50) {
+    return 'orange'
+  } else {
+    return 'red'
+  }
+}