TRACE Main PR #771
TRACE Main PR #771
Conversation
trace mode. will be done in trace itself.
…d into tigerchenlu98-newTRACE_FULL_tiger
|
Wow! This looks great! I looked over it just now and only found very minor things. I want to stare at it a little longer, just to make sure. But I think we're basically done! |
docs/integrators.md
Outdated
|
|
||
| - Default switching function | ||
|
|
||
| This is a similar (but slightly modified) switching function used in MERCURY and MERCURIUS. |
There was a problem hiding this comment.
This needs to be a bit expanded. What is the default switching function?
There was a problem hiding this comment.
Don't know how much detail we want to go into in the docs, but how does it look now?
|
Please merge in my branch Then see the two small queries above. |
|
Both done! |
|
I pushed a few updates to the notebooks (you can merge my Not sure why the windows tests sometimes (?) fail. Does not seem related to TRACE. We either need to revert the primordial earth example to use mercurius, or update it (it still mentions Mercurius), depending on what your tests show. |
|
Squash merged. I kept the old Primordial Earth for now. We can update it any time if we want to. |
Hi Hanno,
Here's the hopefully final PR! Things look pretty clean (except the notebooks, don't think there's a way around that). I replaced all the examples, the only one which is doing worse is PrimordialEarth - not sure why, I need to look into it more.
Let me know if everything looks good!
Tiger