Change component generator examples to domain-specific ones #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cllns
force-pushed
the
tidy-component-generator
branch
from
281dbd7
to
2c713df
Compare
cllns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component generator was created before the operation generator. It's potentially confusing to generate a component called "operation", since we have an operation generator.
I don't think services is a terrific alternative (since it's often used in the same way as operation) so please let me know if anyone has any better ideas. Just wanted to open this so I don't forgetI brainstormed some domain-specific components someone could want for a bookshelf app. Open to other suggestions (in particular ISBN should be an acronym, but it's not in the default inflector, so I think it's find to render it as
Isbn, but it's not ideal)