Remove package-lock.json
#1400
Merged
Remove package-lock.json
#1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my understanding, a project should only have one lock file. At the moment, we have both `package-lock.json` and `yarn.lock`. Because we're currently deploying using `yarn.lock` (on Vercel) and it seems to be more active/used, I've decided to drop the `package-lock.json`. https://github.com/hackclub/site/commits/main/package-lock.json https://github.com/hackclub/site/commits/main/yarn.lock
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Could someone please sanity check this? |
|
Seeing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding, a project should only have one lock file. At the moment, we have both
package-lock.jsonandyarn.lock.Because we're currently deploying using
yarn.lock(on Vercel) and it seems to be more active/used, I've decided to drop thepackage-lock.json.https://github.com/hackclub/site/commits/main/package-lock.json
https://github.com/hackclub/site/commits/main/yarn.lock