Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional parameter to
access.py
'spost
function, as thedownloads/add/
endpoint's input must be formatted "using “application/x-www-form-urlencoded” (or “multipart/form-data” for file upload)". This allowed me to fixDownload.add_download_task_from_url
, but I have a big hunch thatDownload.add_download_task_from_file
could also be affected by this issue.I also fixed
Download.add_download_task_from_url
's documentation that previously indicated that its parameter was supposed to be a string even though the typing indicated in the function declaration is of aDict[str, Any]
.I would also suggest referencing the
download_url_schema
variable inDownload.add_download_task_from_url
's documentation.PS : Sorry for the typo in the commit name on my side !
Tests results (tell me if that's not what you're looking for) :