Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete spark 2.4.x version #379

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

alfonsorr
Copy link
Member

Spark 2.4 is based on Scala 2.11, and is not as used as it was a year ago. Some of the plugins we use are in old versions due to lack of updated versions for 2.11.

Description

Deleted all references to spark 2.4.x

Related Issue and dependencies

#241 scala steward will be able to update scoverage plugin again

How Has This Been Tested?

All test should pass

  • This pull request contains appropriate tests?:
    • YES
    • Something relevant to mention

@alfonsorr alfonsorr requested a review from a team as a code owner July 25, 2023 14:35
@github-actions github-actions bot added spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_2.4 PR changes to spark 2.4 labels Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

:octocat: This is an auto-generated comment created by:

  • Date : 2023-08-09 17:06:46 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 5811996203
  • Commit : 2f32afe Apply suggestions from code review

Co-authored-by: Eduardo Ruiz Alonso [email protected]

Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
3.0.0 684 passed, 2 skipped
3.0.1 684 passed, 2 skipped
3.0.2 684 passed, 2 skipped
3.0 684 passed, 2 skipped
3.1.0 712 passed, 2 skipped
3.1.1 712 passed, 2 skipped
3.1.2 712 passed, 2 skipped
3.1 712 passed, 2 skipped
3.2.0 716 passed, 2 skipped
3.2.1 716 passed, 2 skipped
3.2.2 716 passed, 2 skipped
3.2 716 passed, 2 skipped
3.3.0 716 passed, 2 skipped
3.3.1 716 passed, 2 skipped
3.3 716 passed, 2 skipped
3.4 716 passed, 2 skipped

@github-actions github-actions bot added the CI/CD Continuous integration and continuous delivery label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #379 (2f32afe) into main (d4e684c) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   97.61%   97.69%   +0.08%     
==========================================
  Files          62       62              
  Lines        1256     1255       -1     
  Branches       17       37      +20     
==========================================
  Hits         1226     1226              
+ Misses         30       29       -1     
Flag Coverage Δ
spark-2.4.x ?
spark-3.0.x 96.71% <ø> (-0.04%) ⬇️
spark-3.1.x 97.45% <ø> (-0.05%) ⬇️
spark-3.2.x 97.66% <ø> (-0.05%) ⬇️
spark-3.3.x 97.66% <ø> (-0.05%) ⬇️
spark-3.4.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....0_3.1/scala/doric/syntax/BinaryColumns30_31.scala 100.00% <ø> (ø)
....0_3.1/scala/doric/syntax/NumericColumns2_31.scala 100.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e684c...2f32afe. Read the comment docs.

@alfonsorr alfonsorr force-pushed the feature/delete_spark_2.4 branch 2 times, most recently from a6ee0a6 to 142d3d3 Compare July 26, 2023 08:04
@alfonsorr alfonsorr changed the title Documentation update to show new version Delete spark 2.4.x version Jul 26, 2023
@alfonsorr alfonsorr enabled auto-merge (squash) July 26, 2023 16:04
.github/codecov.yml Show resolved Hide resolved
@eruizalo
Copy link
Collaborator

you should update the doc as well

@alfonsorr alfonsorr force-pushed the feature/delete_spark_2.4 branch 2 times, most recently from b40c9fa to ede2f6f Compare July 31, 2023 16:27
docs/docs/docs/api.md Outdated Show resolved Hide resolved
docs/docs/docs/quickstart.md Outdated Show resolved Hide resolved
@alfonsorr alfonsorr merged commit 46e471b into hablapps:main Aug 9, 2023
46 checks passed
@alfonsorr alfonsorr deleted the feature/delete_spark_2.4 branch August 9, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration and continuous delivery spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants