Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minio migration script #277

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

sougata-progress
Copy link

@sougata-progress sougata-progress commented Oct 15, 2024

story : CHEF-16458

Signed-off-by: sougata-progress <[email protected]>
Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the migration is happening in this PR. It looks like it checks if the latest core/minio is installed and if not it installs it. What it needs to do is check if the core/minio is <= 2023-11-01T01-57-10Z. If core/minio is not installed of if the version is > 2023-11-01T01-57-10Z then do nothing and let the provision.sh script do its thing. If they are <= 2023-11-01T01-57-10Z then their minio data needs to be migrated (see https://github.com/habitat-sh/on-prem-builder/blob/main/scripts/minio-update.sh).

You will want to test this by having a stable stand alone builder server setup with some installed packages. Then follow https://github.com/habitat-sh/on-prem-builder/blob/main/on-prem-docs/upgrading.md to do an upgrade. After the upgrade you should be on the LTS minio and all your packages and package metadata should still be visible in the builder UI and you should be able to download them with the hab binary too.

Note that before doing the update, you should set BLDR_CHANNEL to unstable in the bldr.env file to get the latest builder packages.

scripts/provision.sh Outdated Show resolved Hide resolved
Signed-off-by: sougata-progress <[email protected]>
Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing in addition to the comments, what if any of these is not installed: 'core/aws-cli' 'core/bc' 'core/coreutils'? I think we need to make sure they are installed and install if not present. At least aws-cli. Need to check if we need the others.

scripts/provision.sh Outdated Show resolved Hide resolved
scripts/provision.sh Outdated Show resolved Hide resolved
scripts/provision.sh Show resolved Hide resolved
scripts/provision.sh Show resolved Hide resolved
scripts/provision.sh Show resolved Hide resolved
scripts/provision.sh Show resolved Hide resolved
scripts/provision.sh Outdated Show resolved Hide resolved
scripts/provision.sh Outdated Show resolved Hide resolved
scripts/provision.sh Show resolved Hide resolved
scripts/provision.sh Outdated Show resolved Hide resolved
scripts/provision.sh Outdated Show resolved Hide resolved
Signed-off-by: sougata-progress <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants