Fixing Disable and Re-enable not working fixes #167 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regan-Dryke
changed the title
|
Tested this PR and the disable/re-enable works (as it doesn't work with current master branch version), it would be nice to get this PR merged. |
|
any feedback on why this is not merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting bugs that prevented the Disable and Enable option from working.
Using addon_name was never equal to the name in the AddonsList creating a scenario where disable and enable were never executed properly.
Added some conditions to handle disabling arcdps also disabling all other arcdps modules and same for re-enabling. (Should probably come back to redo this part as I think it doesn't handle some cases.)
Note: The delete option should probably be looked at.