-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated main.rkt to support selective generation of rosette's output-… #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful!!!! Great initiative on adding this!!!
bin/main.rkt
Outdated
@@ -144,6 +145,7 @@ | |||
(error "Output signal must be specified as <name>:<bw>")) | |||
(verilog-module-out-signal (first splits)) | |||
(verilog-module-out-bitwidth (string->number (second splits))))] | |||
["--output-smt-path" v "Specify the output of the SMT solver to a file." (output-smt-path v)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path actually refers to the directory where the files will be placed, not the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops yeah you're right, I'll change the line to reflect this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this thread, still unresolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you accidentally deleted main.rkt...
…sampl/lakeroad into enable_rosette_smt_output_via_cmdline
Dang, thanks for checking this... I think this somehow happened when I was trying to pipe the I think the issue should be resolved now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-added main.rkt
. I think this PR should be good to go
bin/main.rkt
Outdated
@@ -128,6 +129,7 @@ | |||
(when (not (file-exists? v)) | |||
(error (format "File ~a does not exist." v))) | |||
(verilog-module-filepath v))] | |||
["--output-smt-path" v "Specify the output of the SMT solver to a file." (output-smt-path v)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this is a directory, not a file. Please change the docstring here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When CI goes through, go ahead and merge!
…smt feature from the commandline
(PR in response to @gussmith23's issue)
What this change does:
This change modifies
main.rkt
to support the command line flag--output-smt-path "path"
. The specified path will be used as the output to Rosette'soutput-smt
feature.The path you specify will become a folder, as there may be many SMT output files generated and placed in the selected path.
How this change does it:
It adds a new parameter,
output-smt-path
(initially set to#f
) tomain.rkt
.If
output-smt-path
becomes no longer equal to#f
(i.e. it has been assigned in the commandline arguments to become something), the SMT output feature of Rosette will be activated. The output will be directed to the path specified.How to use this change (see line 2 of the below code block):