Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ledger ETH #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HardCorePawn
Copy link

Ledger Ethereum Wallet uses a non-BIP44 compatible Derivation Path of m/44'/60'/0'

Add in an "Ethereum Ledger" option to the "Wallet Type" dialog, that uses this path instead of BIP44 m/44'/60'/0'/0'

Ledger Ethereum Wallet uses a non-BIP44 compatible Derivation Path of m/44'/60'/0' 

Add in an "Ethereum Ledger" option to the "Wallet Type" dialog, that uses this path instead of BIP44 m/44'/60'/0'/0'
@frama77
Copy link

frama77 commented Dec 21, 2017

I have a Gulden wallet back up file (with password) but somehow I forgot the PIN to spend this cryptocurrency. Do you know if I can use the same tools for btcrecover?

@insightsan
Copy link

insightsan commented Jun 18, 2019

Just want to add some findings to this.

I used btcrecover succesfully last night for a mistaken word (embrace instead of enhance :P).

It seems that Ledger Live has changed to BIP44's deriviation path in 2018 MyCryptoHQ/MyCrypto#2070.

I used my known address and my 24 word seed phrase. I then selected option in attached image
image This corresponds the base deriviation path of m/44'/60'/0'/0/.

By putting my bad seed phrase and searching address, it was able to find the correct word and hence phrase.

I am not sure whether this is the same for non-ledger live derivation paths, but this PR may no longer be applicable due to the change.

Maybe the dialog in the screenshot above should also be updated to match this new spec change? It says "NOT Ledger" however it does work for Ledger Live at least.

Also I found that myetherwallet.com still displays the old derivation path for ledger live when you select a hardware wallet lol. That one sent me panicking.

@HardCorePawn
Copy link
Author

Yeah... PRE-Ledger Live... The Ledger generates ETH addresses based on: m/44'/60'/0'

With Ledger Live it generates using: m/44'/60'/0'/0'

So anyone who used the Ledger to generate an ETH address prior to Ledger Live (such as myself) will be on the "old" (non-standard) derivation path... and anyone who generated their first ETH address using a Ledger device since Ledger Live was released will have the more "standard" derivation path.

Repository owner deleted a comment from Janechess Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants