fix: Traverse symlink folders #122
Conversation
| if (err) { | ||
| return cb(err); | ||
| } |
There was a problem hiding this comment.
I'm not really sure what to do about the error handling here. This cb tells the queue an error occured, but presumably dirents.forEach(processDirent); will continue processing, which could potentially error again...
Should it instead just throw the error and hope queue catches and emits it properly?
There was a problem hiding this comment.
Thanks for pointing this out! It has me rethinking how things are queued, but I'll make those changes after I land this
|
Neat - thanks for the quick review and getting this one in @phated. Do you think we could cut a release of vinyl-fs with this version? I'm happy to PR whatever's needed for that (just version bump?) |
|
On WSL, it introduced a bug with maximum call stack on i18next-scanner package. Despite the fact that I do not have symlinks inside my project, it reaches the maximum call stack. I have downgraded glob-stream to 8.0.0 and it resolved the issue. All our current projects that were using i18next-scanner started to fail if glob-stream was updated to 8.0.1 |
|
@sunnysonx Please check in on the conversation in #125. A reproduction, or some debugging to understand what path it is choking on would be appreciated 🙏 |
|
@joshhunt I'm sorry, idk how it happened that I searched across all involved packages, but it seems that I ommited to search in glob-stream. Thank you |
#118 introduced a slight regression where symlinked directories would not be traversed during walkdir. This PR checks if dirents are symlinks + and traverses them as appropriate.
Fixes gulpjs/vinyl-fs#349