Explicitly specify the encoding while reading the readme file. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumegenthial
requested changes
Apr 12, 2019
| @@ -14,8 +14,8 @@ def has_gpu(): | |||
| return False | |||
|
|
|||
|
|
|||
| with open("README.md", "r") as fh: | |||
| long_description = fh.read() | |||
| with open("README.md", "rb") as fh: | |||
There was a problem hiding this comment.
You should specify the encoding directly in the open() call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the readme file contains a Unicode character, on some systems such as docker container when the terminal encoding is not proper, the setup fails with the following error:
The error is generated while reading the readme file in setup.py
This pull request will resolve this issue. The proposed solution is tested for Python 2.7 and Python 3.5.