Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display balances in Accounts view #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

j3k0
Copy link
Contributor

@j3k0 j3k0 commented Nov 7, 2016

This conflicts with the other PR (but fix is easy, see my own master branch).

As for multiple currency bug, I do use multiple currencies and it works fine for me (maybe it depends on ledger version?). If you have an example of a failing transaction I can try to do something about it.

I suppose forcing ledgers' output format would be less prone to incompatibility with future version too.

@guillaumechereau
Copy link
Owner

I still don't like this one much:

  • On my test files, it displays one line per currency for each account. I would rather have all the currencies amounts on the same line.
  • The branch does other things that should be done in a separate PR

@guillaumechereau
Copy link
Owner

What I actually would like to get is an account view that could look somehow like this:

Accounts
Incomes           1,000 EUR + 2,500 USD
    Project A       500 EUR
    Project B       500 EUR
    Project C     2,500 USD

@guillaumechereau
Copy link
Owner

OK, for the moment what I did is allow to move from the account view to the balance view (with 'b').
I think it would make sense to directly start from the balance view and totally remove the accounts view.

@j3k0
Copy link
Contributor Author

j3k0 commented Nov 7, 2016

I agree, no point for having both a view for seeing accounts without balances and one with balances.

@guillaumechereau
Copy link
Owner

It's been a while, but I think the reason I did like that at the time was because I wanted to see even empty accounts. Is there a way in ledger to show empty accounts in the balance report?

@j3k0
Copy link
Contributor Author

j3k0 commented Nov 7, 2016

Yes: balance with --empty flag

BTW I just tried your master branch, select doesn't work from the balance view.

@guillaumechereau
Copy link
Owner

I didn't know about --empty. I will see if I can use it.
Yes I also need to implement the selection from the balance view. After that I guess we could remove the account view totally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants