Pass command code to errorHandler
during processCmd
#368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an invalid structured
FOR
command in a document, such as:this raises an exception from
processForIf
which gets caught by thecatch
after this try block:Currently, only the
err
is passed through to theerrorHandler
, whereas all other calls to theerrorHandler
are supplied with a second argument, the command code (ref: https://github.com/guigrpa/docx-templates/#custom-error-handler).This PR adjusts the
processCmd
flow slightly to ensure that the command code is available in thecatch
block. The movedsplitCommand
does not throw exceptions so this is safe to be moved up in order to makecmdRest
available to thecatch
.Tests have been added for the invalid
FOR
structure above, both with and without anerrorHandler
which didn't appear to be tested previously.