XML command #223
Open
XML command #223
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reply. I'm usually a bit apprehensive about new functionality in this library, as stability is my primary concern at the moment. This looks nice though. Injecting formatting into reports using XML is still pretty hard, this would make it simpler. Can you perhaps add a few snapshot tests? These tests would also serve to showcase the functionality. |
|
Would be really nice to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use literalXml alot with this workaround. It really useful in many circumstances. However, it adds extra 2 paragraphs before and after insertion point which is not ideal. So I came up with this additional XML command, that once inserted, replace existing paragraph the same way other commands did (LINK, IMAGE, HTML).
The literal XML need special treatment if it contains multiple root elements (fragment). I opt to put them under a root element and add them up to the xml node tree if the root presented.