gtk: Add missing IMContextImpl methods #1394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/subclass
branch
from
26f85b7
to
3228868
Compare
sdroege
reviewed
May 8, 2023
| let imp = instance.imp(); | ||
|
|
||
| imp.set_surrounding_with_selection( | ||
| &glib::GString::from_glib_none_num(text, len as usize), |
There was a problem hiding this comment.
Why create a copy here, and not use e.g. glib::GStr?
There was a problem hiding this comment.
IIRC, we don't use glib::GStr in subclassing code at all. That is why I kept it using &str. But anyways, will update once #1678 lands
There was a problem hiding this comment.
It might be useful to use if otherwise you just have to convert to a NUL-terminated string again in the end. I don't know if that's the case here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388