Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Remove type parameter from Object::has_property() and add separate has_property_with_type() and check for subtypes #1565

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

glib: Remove type parameter from Object::has_property() and add separate has_property_with_type() and check for subtypes #1565

wants to merge 2 commits into from
+31 −24

Conversation

sdroege
Copy link
Member

@sdroege sdroege commented Nov 6, 2024 

commit 84cd3fd35f5675f4aa882b47c237a24923122cd1
Author: Sebastian Dröge <[email protected]>
Date:   Wed Nov 6 10:19:15 2024 +0200

    glib: Also check for subtypes in `Object::has_property_with_type()`

commit 41daf6c82b0ed26b2b589ef2caed7b7e42cadc8c
Author: Sebastian Dröge <[email protected]>
Date:   Wed Nov 6 10:17:00 2024 +0200

    glib: Remove type parameter from `Object::has_property()` and add separate `has_property_with_type()`
    
    Most of the time the property type is not interesting and the `None`
    makes the code harder to understand. Having a separate, more descriptive
    function for also checking the type seems better.

@sdroege
glib: Remove type parameter from Object::has_property() and add sep…
883d630 
…arate `has_property_with_type()`

Most of the time the property type is not interesting and the `None`
makes the code harder to understand. Having a separate, more descriptive
function for also checking the type seems better.
@sdroege
glib: Also check for subtypes in Object::has_property_with_type()
722ad59
@sdroege
Copy link
Member Author

sdroege commented Nov 8, 2024

@bilelmoussaoui Any opinions? :)

@bilelmoussaoui
Copy link
Member

Can you have a property with two types with the same name?

@sdroege
Copy link
Member Author

sdroege commented Nov 8, 2024

No, but that also seems unrelated? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui Awaiting requested review from bilelmoussaoui

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdroege @bilelmoussaoui