Implement basics for subclassing #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example usage is here https://gitlab.freedesktop.org/slomo/gstreamer-rs/commit/735a09e2224d390d9253b24d52e69156d72b4d41 Later I'd like to automatically generate the class structs but that will have to wait a while. It's on my list after I've ported all the GStreamer things though, so next week or the week after probably. Generally, I'd like to do the next steps gradually, one by one, so it would be good to have this merged before everything is in place already. |
EPashkin
reviewed
Nov 19, 2018
|
Looks very good, thanks |
sdroege
force-pushed
the
subclass-basics
branch
2 times, most recently
from
8fc9133
to
a4d8197
Compare
EPashkin
reviewed
Nov 20, 2018
This passes the Rust class struct to glib_wrapper! if configured to do so but still requires it to be manually implemented for the time being.
sdroege
force-pushed
the
subclass-basics
branch
from
a4d8197
to
e90ceae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the Rust class struct to glib_wrapper! if configured to do
so but still requires it to be manually implemented for the time being.
See gtk-rs/glib#392