Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target_os handling #434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GuillaumeGomez
Copy link
Member

Fixes #421.

It's apparently impossible to test it for the moment, so I propose we keep it open, laugh about it from time to time and then forget it unless some unbelievable event makes it testable.

@EPashkin
Copy link
Member

EPashkin commented Aug 9, 2017

While this can handled with cfg_condition this make config more clear.
Thanks, @GuillaumeGomez

@GuillaumeGomez
Copy link
Member Author

The only issue is that we don't have any use for it for the moment. :-/

@sdroege
Copy link
Member

sdroege commented Aug 9, 2017

What would be the use case for this, one that actually can work with gobject-introspection as it is now? :)

@GuillaumeGomez
Copy link
Member Author

That's exactly my point. I made this change and then wondered: "when could we use this?". And after realising it was completely useless, I decided to open the PR just in case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants