Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getter and setter annotations #1571

Merged
merged 5 commits into from
Jun 2, 2024

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Jun 1, 2024

No description provided.

@A6GibKm A6GibKm force-pushed the getter-setters branch 4 times, most recently from 69e6ebc to 3820a43 Compare June 1, 2024 13:39
@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jun 1, 2024

CI fails because the setter for GtkImage:paintable actually is set_from_paintable

@A6GibKm A6GibKm force-pushed the getter-setters branch 3 times, most recently from edcc513 to b1a5ad7 Compare June 1, 2024 17:10
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if @bilelmoussaoui is happy with the renegenerated gtk4-rs too

@bilelmoussaoui bilelmoussaoui merged commit 0a0288d into gtk-rs:master Jun 2, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants