codegen: Use async keyword for not in traits functions #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the Pin<Box<T>> only for in trait async funcitons. Reduces the generated code a little bit :)
bilelmoussaoui
force-pushed
the
bilelmoussaoui/async-in-impl
branch
from
e469948
to
afc2a7e
Compare
sdroege
reviewed
Jul 10, 2023
| async_future.success_parameters, error_parameters | ||
| ) | ||
| } else { | ||
| if in_trait { |
There was a problem hiding this comment.
gtk-rs/gtk4-rs#1421 (comment) FWIW. This will now create differently behaving API depending on whether it's in a trait or not
sdroege
reviewed
Jul 10, 2023
That is a possibility yes, I can find some time for that later. |
Should make this PR only simpler, I guess :) |
|
Now that async traits are stable, should we re-consider this and bump the minimal required rust version? |
|
Not yet, see the announcement of the stabilization of the feature. It explicitly asked people to wait using it for public API for various reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the Pin<Box> only for in trait async functions. Reduces the generated code a little bit :)
gtk4-rs PR: gtk-rs/gtk4-rs#1421