support fundamental types #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing the title, is this something I could leverage for #1134? |
Not really, the ones this PR attempts to fix are fundamental types in "glib terms", so they do provide a ref/unref/get_type functions |
|
That's unfortunate, I thought this added a way to specify fundamental types (somehow) in |
|
Can you create a WIP PR for gtk4-rs? |
Will do once it's +/- compiling locally |
bilelmoussaoui
changed the title
bilelmoussaoui
commented
Dec 29, 2021
|
It should be ready for a review :) It can properly generate things like |
sdroege
reviewed
Jan 1, 2022
|
Looks good to me otherwise. Less code than I feared :) |
|
Good to merge then? |
|
Looks good to me yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request allows generating a portion of the code needed for fundamental types. It still needs manual code to create a common trait & implement it for the various sub-types along with the casting functions.
The PR as is, allows to drop a huge portion of the manual code in gtk4-rs.
The next step before merging this is to automatically use
AsRef<T>instead ofIsA<T>where needed.Fixes #1069