This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Update examples for the latest regen #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
You also have to update the minimum version to 1.39 from 1.36 |
|
@GuillaumeGomez good to go :) |
alatiera
commented
Nov 18, 2019
Also remove the futures feature and move to 0.3 from 0.3.preview
sfanxiang
reviewed
Nov 18, 2019
| @@ -7,8 +7,8 @@ extern crate gio; | |||
| extern crate glib; | |||
| extern crate gtk; | |||
|
|
|||
| use gio::prelude::ApplicationExtManual; | |||
| use gio::ApplicationExt; | |||
There was a problem hiding this comment.
nit: Should we also use gio::prelude::ApplicationExt; here, for consistency?
There was a problem hiding this comment.
No, we should use gio::prelude::* here for both :)
|
I'm slightly worried by the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the futures feature and move to 0.3 from 0.3.preview